Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix telemetry not getting picked up for Terminal REPL #23958

Merged
merged 3 commits into from
Aug 16, 2024

Conversation

anthonykim1
Copy link

@anthonykim1 anthonykim1 commented Aug 16, 2024

#23941
Having no blank spaces in front of plain 'python' or 'python3' were returning falsey value.

Also comply to new ruff rule.

@anthonykim1 anthonykim1 self-assigned this Aug 16, 2024
@anthonykim1 anthonykim1 added area-repl bug Issue identified by VS Code Team member as probable bug skip tests Updates to tests unnecessary labels Aug 16, 2024
@anthonykim1 anthonykim1 marked this pull request as ready for review August 16, 2024 20:17
@vs-code-engineering vs-code-engineering bot added this to the August 2024 milestone Aug 16, 2024
justschen
justschen previously approved these changes Aug 16, 2024
@anthonykim1 anthonykim1 enabled auto-merge (squash) August 16, 2024 20:33
@anthonykim1 anthonykim1 marked this pull request as draft August 16, 2024 20:39
auto-merge was automatically disabled August 16, 2024 20:39

Pull request was converted to draft

justschen
justschen previously approved these changes Aug 16, 2024
@anthonykim1 anthonykim1 marked this pull request as ready for review August 16, 2024 20:56
@anthonykim1 anthonykim1 enabled auto-merge (squash) August 16, 2024 20:56
@anthonykim1 anthonykim1 mentioned this pull request Aug 16, 2024
@anthonykim1 anthonykim1 merged commit e9f1071 into microsoft:main Aug 16, 2024
40 checks passed
anthonykim1 added a commit to anthonykim1/vscode-python that referenced this pull request Sep 13, 2024
microsoft#23941 
Having no blank spaces in front of plain 'python' or 'python3' were
returning falsey value.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area-repl bug Issue identified by VS Code Team member as probable bug skip tests Updates to tests unnecessary
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants